Add downstream-check CI (builds Strata-CLI against Python PRs)#3
Draft
shigoel wants to merge 2 commits into
Draft
Add downstream-check CI (builds Strata-CLI against Python PRs)#3shigoel wants to merge 2 commits into
shigoel wants to merge 2 commits into
Conversation
Advisory, non-blocking check: builds Strata-CLI against this PR's Strata-Python code (CLI requires StrataPython) to catch breakage before it lands on main. CLI has no lake testDriver, so it verifies via the binary + examples, mirroring CLI's own ci.yml. Reuses Strata's composite actions via @main. Depends on strata-org/Strata#1387 landing first.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The issue_comment trigger runs in the privileged default-branch context; building untrusted PR code there is a cache-poisoning / code-execution vector (CodeQL actions/cache-poisoning/poisonable-step). Run only on pull_request, which builds the same code in an isolated, unprivileged context. Collapses the gate job into a job-level draft check and reads the PR head SHA from the event payload (no shared gate action needed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Advisory, non-blocking cross-repo check: when a Strata-Python PR is ready (or a collaborator comments
!downstream-check), build Strata-CLI against this PR's Strata-Python code (CLIrequires StrataPython) to catch breakage before it lands onmain. Result shows up as aDownstream / Strata-CLIjob on the PR.Strata-CLI has no lake
testDriver, so verification mirrors CLI's ownci.yml: build, thenlake exe strata --help+./scripts/run_examples.sh.Mechanism
Checks out the PR's Strata-Python, clones Strata-CLI, rewrites CLI's
require "StrataPython"to a local path (fork-safe), thenlake update StrataPython+ build + checks. CLI's other requires (Strata, StrataDDM atmain) resolve normally — only the StrataPython edge is overridden. Reuses Strata's composite actions via@main.Depends on
main). Until then this check will error (expected). See #1387 for the full design.Draft for early feedback.